[webkit-changes] [WebKit/WebKit] 8338db: [CSS] Implement supports() after @import rule

Matthieu Dubet noreply at github.com
Fri Jan 26 17:47:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8338db44d91898abef308bf185572c5fd0fdfc69
      https://github.com/WebKit/WebKit/commit/8338db44d91898abef308bf185572c5fd0fdfc69
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/import-conditions-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/import-conditions.html
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssimportrule-expected.txt
    A LayoutTests/platform/gtk-wk2/imported/w3c/web-platform-tests/css/css-cascade/import-conditions-expected.txt
    A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/import-conditions-expected.txt
    M Source/WebCore/css/CSSImportRule.cpp
    M Source/WebCore/css/CSSImportRule.h
    M Source/WebCore/css/CSSImportRule.idl
    M Source/WebCore/css/StyleRuleImport.cpp
    M Source/WebCore/css/StyleRuleImport.h
    M Source/WebCore/css/parser/CSSParser.cpp
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/css/parser/CSSSupportsParser.cpp
    M Source/WebCore/css/parser/CSSSupportsParser.h
    M Source/WebCore/style/RuleSetBuilder.cpp

  Log Message:
  -----------
  [CSS] Implement supports() after @import rule
https://bugs.webkit.org/show_bug.cgi?id=256180
rdar://109060734

Reviewed by Antti Koivisto.

https://drafts.csswg.org/css-cascade-5/#conditional-import
https://drafts.csswg.org/css-conditional-3/#typedef-supports-condition

The syntax is: [ supports( [ <supports-condition> | <declaration> ] ) ]?

Like for the CSS.window.supports API, the supports() after @import
allows bare declaration.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/import-conditions-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/import-conditions.html:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssimportrule-expected.txt:
* LayoutTests/platform/gtk-wk2/imported/w3c/web-platform-tests/css/css-cascade/import-conditions-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/import-conditions-expected.txt: Added.
* Source/WebCore/css/CSSImportRule.cpp:
(WebCore::CSSImportRule::layerName const):
(WebCore::CSSImportRule::supportsText const):
(WebCore::CSSImportRule::cssTextInternal const):
* Source/WebCore/css/CSSImportRule.h:
* Source/WebCore/css/CSSImportRule.idl:
* Source/WebCore/css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
* Source/WebCore/css/StyleRuleImport.h:
* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSupportsCondition):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeImportRule):
(WebCore::CSSParserImpl::consumeSupportsRule):
* Source/WebCore/css/parser/CSSSupportsParser.cpp:
(WebCore::CSSSupportsParser::supportsCondition):
* Source/WebCore/css/parser/CSSSupportsParser.h:
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addRulesFromSheetContents):

Canonical link: https://commits.webkit.org/273591@main




More information about the webkit-changes mailing list