[webkit-changes] [WebKit/WebKit] a04c3b: Setup MASM CMake support

Don Olmstead noreply at github.com
Fri Jan 26 17:11:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a04c3b4e0a4efaa58576a7e106ba5cdfa18b19bb
      https://github.com/WebKit/WebKit/commit/a04c3b4e0a4efaa58576a7e106ba5cdfa18b19bb
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/WTF/wtf/CMakeLists.txt
    M Source/WTF/wtf/PlatformWin.cmake
    M Source/cmake/OptionsMSVC.cmake

  Log Message:
  -----------
  Setup MASM CMake support
https://bugs.webkit.org/show_bug.cgi?id=268188

Reviewed by Yusuke Suzuki.

Centralize the MASM setup within `OptionsMSVC.cmake`. Override the MASM
compile command to prevent unsupported flags from `add_compile_options`
and `add_definitions` from being passed to the assembler.

Remove custom commands for compiling the MASM files and add them like
normal sources. Move the compilation in WTF into the main
`CMakeLists.txt`. Simplify code to account for x86 being C loop only.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/PlatformWin.cmake:
* Source/cmake/OptionsMSVC.cmake:

Canonical link: https://commits.webkit.org/273588@main




More information about the webkit-changes mailing list