[webkit-changes] [WebKit/WebKit] dbc691: AX: AccessibilityUIElement::childrenCount, childAt...

AndresGonzalezApple noreply at github.com
Fri Jan 26 06:30:28 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbc6912a853950fe1171a7d0bc015c015f6209c8
      https://github.com/WebKit/WebKit/commit/dbc6912a853950fe1171a7d0bc015c015f6209c8
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp

  Log Message:
  -----------
  AX: AccessibilityUIElement::childrenCount, childAtIndex duplicates code in COCOA platforms.
https://bugs.webkit.org/show_bug.cgi?id=268101
<rdar://problem/121618624>

Reviewed by Chris Fleizach.

This patch shares the implementation of these methods in the COCOA platforms, and includes some code cleanup in this class implementation.

* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::childAtIndex):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::getChildren const):
(WTR::AccessibilityUIElement::getChildrenInRange const):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::getChildren): Deleted.
(WTR::AccessibilityUIElement::getChildrenWithRange): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::getChildren const):
(WTR::AccessibilityUIElement::getChildrenInRange const):
(WTR::AccessibilityUIElement::getChildren): Deleted.
(WTR::AccessibilityUIElement::getChildrenWithRange): Deleted.
(WTR::AccessibilityUIElement::childrenCount): Deleted.
(WTR::AccessibilityUIElement::childAtIndex): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::getChildren const):
(WTR::AccessibilityUIElement::getChildrenInRange const):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::getChildren): Deleted.
(WTR::AccessibilityUIElement::getChildrenWithRange): Deleted.
(WTR::AccessibilityUIElement::childrenCount): Deleted.
(WTR::AccessibilityUIElement::childAtIndex): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::getChildren const):
(WTR::AccessibilityUIElement::getChildrenInRange const):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::getChildren): Deleted.
(WTR::AccessibilityUIElement::getChildrenWithRange): Deleted.

Canonical link: https://commits.webkit.org/273560@main




More information about the webkit-changes mailing list