[webkit-changes] [WebKit/WebKit] 7841b2: Remove more webkitpy.common.net.bugzilla and webki...

Sam Sneddon noreply at github.com
Fri Jan 26 03:22:05 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7841b2790f42d00eb2a8a9357a38d9df5509e047
      https://github.com/WebKit/WebKit/commit/7841b2790f42d00eb2a8a9357a38d9df5509e047
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py
    M Tools/Scripts/webkitpy/common/net/bugzilla/bug.py
    M Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py
    M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
    M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
    M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py
    M Tools/Scripts/webkitpy/w3c/common.py
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_exporter.py
    M Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
    M Tools/Scripts/webkitpy/w3c/test_parser.py
    M Tools/Scripts/webkitpy/w3c/wpt_github.py
    M Tools/Scripts/webkitpy/w3c/wpt_github_mock.py
    M Tools/Scripts/webkitpy/w3c/wpt_runner_unittest.py

  Log Message:
  -----------
  Remove more webkitpy.common.net.bugzilla and webkitpy.w3c dead code
https://bugs.webkit.org/show_bug.cgi?id=268094

Reviewed by Jonathan Bedard.

Largely found via `vulture webkitpy --exclude '.tox,*_unittest.py,*_integrationtest.py'`

* Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py:
(Attachment):
(Attachment.id):
(Attachment.is_patch):
(Attachment.name):
(Attachment.attacher): Deleted.
(Attachment.attacher_email): Deleted.
(Attachment.is_obsolete): Deleted.
(Attachment.is_revert): Deleted.
(Attachment.attach_date): Deleted.
* Tools/Scripts/webkitpy/common/net/bugzilla/bug.py:
(Bug.is_closed):
(Bug.patches):
(Bug.reviewed_patches):
(Bug.is_in_comments):
(Bug.duplicate_of): Deleted.
(Bug.unreviewed_patches): Deleted.
(Bug.commit_queued_patches): Deleted.
(Bug.commit_revision): Deleted.
* Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
(BugTest.test_is_in_comments):
(BugTest.test_commit_revision): Deleted.
* Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.__init__):
(BugzillaQueries._load_query):
(BugzillaQueries.fetch_quips):
(Bugzilla.__init__):
(Bugzilla.open_url):
(Bugzilla.bug_url_for_bug_id):
(Bugzilla.attachment_url_for_id):
(Bugzilla._parse_log_descr_element):
(Bugzilla._filename_for_upload):
(Bugzilla.clear_attachment_flags):
(EditUsersParser): Deleted.
(EditUsersParser.__init__): Deleted.
(EditUsersParser._login_and_uid_from_row): Deleted.
(EditUsersParser.login_userid_pairs_from_edit_user_results): Deleted.
(EditUsersParser._group_name_and_string_from_row): Deleted.
(EditUsersParser.user_dict_from_edit_user_page): Deleted.
(EditUsersParser._group_rows_from_edit_user_page): Deleted.
(EditUsersParser.group_string_from_name): Deleted.
(BugzillaQueries._is_xml_bugs_form): Deleted.
(BugzillaQueries._parse_result_count): Deleted.
(BugzillaQueries._fetch_bugs_from_advanced_query): Deleted.
(BugzillaQueries._fetch_bug): Deleted.
(BugzillaQueries._fetch_bug_ids_advanced_query): Deleted.
(BugzillaQueries._parse_attachment_ids_request_query): Deleted.
(BugzillaQueries._fetch_attachment_ids_request_query): Deleted.
(BugzillaQueries.fetch_bug_ids_from_pending_commit_list): Deleted.
(BugzillaQueries.fetch_bugs_matching_quicksearch): Deleted.
(BugzillaQueries.fetch_bugs_matching_search): Deleted.
(BugzillaQueries.fetch_patches_from_pending_commit_list): Deleted.
(BugzillaQueries.fetch_bugs_from_review_queue): Deleted.
(BugzillaQueries.fetch_bug_ids_from_commit_queue): Deleted.
(BugzillaQueries.fetch_patches_from_commit_queue): Deleted.
(BugzillaQueries.fetch_bug_ids_from_review_queue): Deleted.
(BugzillaQueries.fetch_patches_from_review_queue): Deleted.
(BugzillaQueries.fetch_attachment_ids_from_review_queue): Deleted.
(BugzillaQueries.fetch_login_userid_pairs_matching_substring): Deleted.
(Bugzilla.fetch_user): Deleted.
(Bugzilla.add_user_to_groups): Deleted.
(Bugzilla.short_bug_url_for_bug_id): Deleted.
(Bugzilla.edit_user_url_for_id): Deleted.
(Bugzilla._parse_bugs_from_xml): Deleted.
(Bugzilla.add_attachment_to_bug): Deleted.
(Bugzilla.set_flag_on_attachment): Deleted.
* Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.__init__):
(MockBugzilla.fetch_bug):
(MockBugzilla.reassign_bug):
(MockBugzilla.post_comment_to_bug):
(MockBugzillaQueries._all_bugs): Deleted.
(MockBugzillaQueries.fetch_bug_ids_from_commit_queue): Deleted.
(MockBugzillaQueries.fetch_attachment_ids_from_review_queue): Deleted.
(MockBugzillaQueries.fetch_patches_from_commit_queue): Deleted.
(MockBugzillaQueries.fetch_bug_ids_from_pending_commit_list): Deleted.
(MockBugzillaQueries.fetch_bugs_from_review_queue): Deleted.
(MockBugzillaQueries.fetch_patches_from_pending_commit_list): Deleted.
(MockBugzillaQueries.fetch_bugs_matching_search): Deleted.
(MockBugzillaQueries.fetch_bugs_matching_quicksearch): Deleted.
(MockBugzilla.set_override_patch): Deleted.
(MockBugzilla.set_flag_on_attachment): Deleted.
(MockBugzilla.add_attachment_to_bug): Deleted.
* Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_url_creation):
(test_parse_bug_id):
(test_user_dict_from_edit_user_page): Deleted.
* Tools/Scripts/webkitpy/w3c/common.py:
(read_credentials):
(is_testharness_baseline): Deleted.
(is_basename_skipped): Deleted.
(is_file_exportable): Deleted.
* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.__init__):
* Tools/Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._ensure_new_branch_name):
(WebPlatformTestExporter.download_and_commit_patch): Deleted.
* Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:
(TestExporterTest.MockGit.push):
(TestExporterTest.MockGit.format_patch): Deleted.
* Tools/Scripts/webkitpy/w3c/test_importer.py:
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.import_downloaded_tests):
(TestImporterTest.import_downloaded_tests.TestDownloaderMock): Deleted.
(TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__): Deleted.
(TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status): Deleted.
* Tools/Scripts/webkitpy/w3c/test_parser.py:
(TestParser.is_slow_test):
(TestParser.has_fuzzy_metadata): Deleted.
* Tools/Scripts/webkitpy/w3c/wpt_github.py:
(WPTGitHub.__init__):
(WPTGitHub.request):
(WPTGitHub.create_pr):
(WPTGitHub.add_label):
(MergeError.__init__):
(WPTGitHub.extract_link_next): Deleted.
(WPTGitHub.update_pr): Deleted.
(WPTGitHub.remove_label): Deleted.
(WPTGitHub.make_pr_from_item): Deleted.
(WPTGitHub.all_pull_requests): Deleted.
(WPTGitHub.get_pr_branch): Deleted.
(WPTGitHub.is_pr_merged): Deleted.
(WPTGitHub.merge_pr): Deleted.
(WPTGitHub.delete_remote_branch): Deleted.
(WPTGitHub.pr_for_chromium_commit): Deleted.
(WPTGitHub.pr_with_change_id): Deleted.
(WPTGitHub.pr_with_position): Deleted.
* Tools/Scripts/webkitpy/w3c/wpt_github_mock.py:
(MockWPTGitHub.__init__):
(MockWPTGitHub.create_pr):
(MockWPTGitHub.add_label):
(MockWPTGitHub.all_pull_requests): Deleted.
(MockWPTGitHub.is_pr_merged): Deleted.
(MockWPTGitHub.merge_pr): Deleted.
(MockWPTGitHub.update_pr): Deleted.
(MockWPTGitHub.delete_remote_branch): Deleted.
(MockWPTGitHub.remove_label): Deleted.
(MockWPTGitHub.get_pr_branch): Deleted.
(MockWPTGitHub.pr_for_chromium_commit): Deleted.
(MockWPTGitHub.pr_with_position): Deleted.
(MockWPTGitHub.pr_with_change_id): Deleted.
* Tools/Scripts/webkitpy/w3c/wpt_runner_unittest.py:

Canonical link: https://commits.webkit.org/273556@main

More information about the webkit-changes mailing list