[webkit-changes] [WebKit/WebKit] 4c07fa: REGRESSION (273535 at main): Safari crashes when atte...

Wenson Hsieh noreply at github.com
Thu Jan 25 20:29:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c07faaf1f956909e631c214bd126162852e0f4b
      https://github.com/WebKit/WebKit/commit/4c07faaf1f956909e631c214bd126162852e0f4b
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  REGRESSION (273535 at main): Safari crashes when attempting to AutoFill when async text input is disabled
https://bugs.webkit.org/show_bug.cgi?id=268128
rdar://121631848

Reviewed by Aditya Keerthi.

`-insertTextSuggestion:` can take either a `BETextSuggestion` -or- a `UITextSuggestion` instance,
depending on whether `UIKit/async_text_input_*` is enabled. Keep this binary compatible with both
codepaths by using a dynamic cast to `BETextSuggestion` before calling `-_uikitTextSuggestion`.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertTextSuggestion:]):

Canonical link: https://commits.webkit.org/273548@main




More information about the webkit-changes mailing list