[webkit-changes] [WebKit/WebKit] 203579: [LBSE] Fix svg/clip-path/clip-path-on-overflowing....

Rob Buis noreply at github.com
Thu Jan 25 05:03:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 203579d66ae912b7997b43e582ae078c2acfcb92
      https://github.com/WebKit/WebKit/commit/203579d66ae912b7997b43e582ae078c2acfcb92
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
    M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.h
    M Source/WebCore/rendering/svg/RenderSVGContainer.cpp
    M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp
    M Source/WebCore/rendering/svg/RenderSVGImage.cpp
    M Source/WebCore/rendering/svg/RenderSVGRoot.cpp
    M Source/WebCore/rendering/svg/RenderSVGShape.cpp
    M Source/WebCore/rendering/svg/RenderSVGText.cpp

  Log Message:
  -----------
  [LBSE] Fix svg/clip-path/clip-path-on-overflowing.html
https://bugs.webkit.org/show_bug.cgi?id=267832

Reviewed by Nikolas Zimmermann.

Implement support for HTML elements referencing SVG clip paths
that rely on clipping through usage of a mask (support for pure
clip paths was already provided).

Since for non SVG we can't rely on objectBoundingBox(), add a
parameter to paintSVGClippingMask to pass the object bounding
box that should be used.

* LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::paintClippingMask):
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::paintSVGClippingMask const):
* Source/WebCore/rendering/RenderLayerModelObject.h:
* Source/WebCore/rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
* Source/WebCore/rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintObject):
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):

Canonical link: https://commits.webkit.org/273495@main




More information about the webkit-changes mailing list