[webkit-changes] [WebKit/WebKit] 580e58: [72857589b8bce60e] ASAN_ILL | WebCore::TreeScopeOr...

lericaa noreply at github.com
Wed Jan 24 22:26:48 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 580e5844c227041f4e3dc3356948a9568a3b6d15
      https://github.com/WebKit/WebKit/commit/580e5844c227041f4e3dc3356948a9568a3b6d15
  Author: Erica Li <lerica at apple.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    A LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash-expected.txt
    A LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash.html
    M Source/WebCore/svg/SVGAnimateMotionElement.cpp
    M Source/WebCore/svg/SVGAnimateMotionElement.h
    M Source/WebCore/svg/SVGMPathElement.cpp
    M Source/WebCore/svg/SVGMPathElement.h

  Log Message:
  -----------
  [72857589b8bce60e] ASAN_ILL | WebCore::TreeScopeOrderedMap::getElementById; WebCore::TreeScope::getElementById; WebCore::SVGURIReference::targetElementFromIRIString.
https://bugs.webkit.org/show_bug.cgi?id=265562
rdar://118513775

Reviewed by Chris Dumez.

updateAnimationPath should be done after treescope is fully updated.

* LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash-expected.txt: Added.
* LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash.html: Added.
* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::childrenChanged):
* Source/WebCore/svg/SVGAnimateMotionElement.h:
* Source/WebCore/svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::removedFromAncestor):
(WebCore::SVGMPathElement::targetPathChanged):
(WebCore::SVGMPathElement::notifyParentOfPathChange): Deleted.
* Source/WebCore/svg/SVGMPathElement.h:

Originally-landed-as: 267815.611 at safari-7617-branch (ca57f6a1de59). rdar://121480927
Canonical link: https://commits.webkit.org/273473@main




More information about the webkit-changes mailing list