[webkit-changes] [WebKit/WebKit] bba680: Remove non-standard `KeyboardEvent.keyLocation`

Ahmad Saleem noreply at github.com
Wed Jan 24 17:32:01 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bba680e17fee76325be7facc38899eda3f43d419
      https://github.com/WebKit/WebKit/commit/bba680e17fee76325be7facc38899eda3f43d419
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
    M LayoutTests/fast/events/constructors/keyboard-event-constructor.html
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-option-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-shift-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift-expected.txt
    M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-shift-expected.txt
    M Source/WebCore/dom/KeyboardEvent.cpp
    M Source/WebCore/dom/KeyboardEvent.h
    M Source/WebCore/dom/KeyboardEvent.idl

  Log Message:
  -----------
  Remove non-standard `KeyboardEvent.keyLocation`

https://bugs.webkit.org/show_bug.cgi?id=267819

Reviewed by Ryosuke Niwa.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium
by removing non-standard KeyboardEvent.keyLocation (alias of 'location').

It is not in web-specification [1].

[1] https://w3c.github.io/uievents/#events-keyboardevents

It was never shipped in Gecko / Firefox while removed in Blink
in 2016 and with commit [2]:

[2] https://chromium.googlesource.com/chromium/src.git/+/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410

* Source/WebCore/dom/KeyboardEvent.cpp:
(KeyboardEvent::KeyboardEvent):
* Source/WebCore/dom/KeyboardEvent.h:
* Source/WebCore/dom/KeyboardEvent.idl:
* LayoutTests/fast/events/constructors/keyboard-event-constructor.html: Rebaselined
* LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt: Rebaselined
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-expected.txt: Rebaselined
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-option-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-shift-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift-expected.txt: Ditto
* LayoutTests/fast/events/ios/key-events-comprehensive/key-events-shift-expected.txt: Ditto

Canonical link: https://commits.webkit.org/273457@main




More information about the webkit-changes mailing list