[webkit-changes] [WebKit/WebKit] 277c42: [VisionOS] Twitter.com videos do not play

Jer Noble noreply at github.com
Wed Jan 24 11:15:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 277c42bdaccc434bff6fac4e45f23b7f31ca371b
      https://github.com/WebKit/WebKit/commit/277c42bdaccc434bff6fac4e45f23b7f31ca371b
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M Source/WebCore/Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl

  Log Message:
  -----------
  [VisionOS] Twitter.com videos do not play
https://bugs.webkit.org/show_bug.cgi?id=267938
rdar://121391975

Reviewed by Tim Horton.

Twitter.com has adopted ManagedMediaSource, and disables airplay via
HTMLMediaElement.disableRemotePlayback. On other platforms, this allows
MMS to move to the "open" state, due to the managedMediaSourceNeedsAirPlay
setting. However, on VisionOS, the RemotePlaybackEnabled setting is off,
so the disableRemotePlayback property is not reflected into an attribute
on the HTMLMediaElement, and the check for isWirelessPlaybackTargetDisabled()
fails.

Selectively move portions of EnabledBySetting=RemotePlaybackEnabled from
the HTMLMediaElement+RemotePlayback.idl file sufficient for disableRemotePlayback
to be reflected, and to allow ManagedMediaSource to check for its presence.

* Source/WebCore/Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl:

Canonical link: https://commits.webkit.org/273434@main




More information about the webkit-changes mailing list