[webkit-changes] [WebKit/WebKit] ca705e: [GStreamer] Minor improvements and logging for Vid...

Philippe Normand noreply at github.com
Wed Jan 24 07:26:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca705e68c3039dcbeb6146bf21dc2765acfd4418
      https://github.com/WebKit/WebKit/commit/ca705e68c3039dcbeb6146bf21dc2765acfd4418
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h
    M Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Minor improvements and logging for VideoFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=267924

Reviewed by Xabier Rodriguez-Calvar.

The createFromPixelBuffer() should be allowed to fail, when conversion fails. The call sites were
adapted accordingly. Also we were applying the frame metadata twice to those buffers, for no
particular reason.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrame::createFromPixelBuffer):
(WebCore::VideoFrameGStreamer::createFromPixelBuffer):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h:
* Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockRealtimeVideoSourceGStreamer::updateSampleBuffer):

Canonical link: https://commits.webkit.org/273411@main




More information about the webkit-changes mailing list