[webkit-changes] [WebKit/WebKit] a92146: [Glib] Getting stacktrace from systemd fails somet...

Vitaly Dyachkov noreply at github.com
Wed Jan 24 07:12:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a92146e5ba8f2bd1fcd843249aa9652e2852d922
      https://github.com/WebKit/WebKit/commit/a92146e5ba8f2bd1fcd843249aa9652e2852d922
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/port/linux_get_crash_log.py

  Log Message:
  -----------
  [Glib] Getting stacktrace from systemd fails sometimes
https://bugs.webkit.org/show_bug.cgi?id=267999

Reviewed by Adrian Perez de Castro.

When `coredumpctl` is available, we use it to get the stacktrace.
The exact command executed is
`coredumpctl info --since="Wed 2024-01-24 14:48:45 CET"`.

But sometimes it fails to parse the provided datetime:
```
$ coredumpctl info --since="Wed 2024-01-24 14:48:45 CET"
Failed to parse timestamp 'Wed 2024-01-24 14:48:45 CET': Invalid argument
```

According to systemd documentation [1], we can pass the number of
seconds since the UNIX epoch prefixed with `@` instead.

[1] https://www.freedesktop.org/software/systemd/man/latest/systemd.time.html

* Tools/Scripts/webkitpy/port/linux_get_crash_log.py:
(GDBCrashLogGenerator._get_trace_from_systemd):

Canonical link: https://commits.webkit.org/273408@main




More information about the webkit-changes mailing list