[webkit-changes] [WebKit/WebKit] f1f9f0: Remove non-standard `KeyboardEvent.altGraphKey`

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1f9f0045afe3ae23d359d72658b600e4a623ac5
      https://github.com/WebKit/WebKit/commit/f1f9f0045afe3ae23d359d72658b600e4a623ac5
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
    M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
    M LayoutTests/fast/events/constructors/keyboard-event-constructor.html
    M LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt
    M LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html
    M LayoutTests/fast/events/constructors/mouse-event-getModifierState-expected.txt
    M LayoutTests/fast/events/constructors/mouse-event-getModifierState.html
    M LayoutTests/fast/events/init-event-clears-capslock-expected.txt
    M LayoutTests/fast/events/init-event-clears-capslock.html
    M LayoutTests/fast/events/init-events-expected.txt
    M LayoutTests/fast/events/init-events.html
    M LayoutTests/fast/forms/tabs-with-modifiers-expected.txt
    M LayoutTests/fast/forms/tabs-with-modifiers.html
    M Source/WebCore/dom/KeyboardEvent.cpp
    M Source/WebCore/dom/KeyboardEvent.h
    M Source/WebCore/dom/KeyboardEvent.idl
    M Source/WebCore/dom/UIEventWithKeyState.cpp
    M Source/WebCore/dom/UIEventWithKeyState.h
    M Source/WebCore/html/HTMLSelectElementWin.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm

  Log Message:
  -----------
  Remove non-standard `KeyboardEvent.altGraphKey`

https://bugs.webkit.org/show_bug.cgi?id=248394

Reviewed by Chris Dumez.

This pach aligns WebKit with Gecko / Firefox and Blink / Chromium
by removing non-standard KeyboardEvent.altGraphKey.

It is not in web-specification [1].

[1] https://www.w3.org/TR/uievents/

It was never shipped in Gecko / Firefox while removed in Blink
in 2014 and with commit [2]:

[2] https://src.chromium.org/viewvc/blink?view=revision&revision=179545

> Files modified:
* Source/WebCore/dom/KeyboardEvent.cpp:
(KeyboardEvent::initKeyboardEvent):
* Source/WebCore/dom/KeyboardEvent.h:
* Source/WebCore/dom/KeyboardEvent.idl:
* Source/WebCore/dom/UIEventWithKeyState.cpp:
(UIEventWithKeyState::getModifierState):
(UIEventWithKeyState::setModifierKeys):
* Source/WebCore/dom/UIEventWithKeyState.h:
* Source/WebCore/html/HTMLSelectElementWin.cpp:
(HTMLSelectElement::platformHandleKeydownEvent):
* Source/WebCore/page/EventHandler.cpp:
(EventHandler::defaultPageUpDownEventHandler):
(EventHandler::defaultHomeEndEventHandler):
(EventHandler::defaultArrowEventHandler():
(EventHandler::defaultTabEventHandler):
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp:
(webkit_dom_keyboard_event_init_keyboard_event):
(webkit_dom_keyboard_event_get_alt_graph_key):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(PDFPluginTextAnnotation::value):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebPage::handleKeyEventByRelinquishingFocusToChrome):
* Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm:
((BOOL)altGraphKey):
((void)initKeyboardEvent):

> Tests Rebaselined / Updated:
* LayoutTests/fast/forms/tabs-with-modifiers.html:
* LayoutTests/fast/forms/tabs-with-modifiers-expected.txt:
* LayoutTests/fast/events/init-events.html:
* LayoutTests/fast/events/init-events-expected.txt:
* LayoutTests/fast/events/init-event-clears-capslock.html:
* LayoutTests/fast/events/init-event-clears-capslock-expected.txt:
* LayoutTests/fast/events/constructors/mouse-event-getModifierState.html:
* LayoutTests/fast/events/constructors/mouse-event-getModifierState-expected.txt:
* LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html:
* LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt:
* LayoutTests/fast/events/constructors/keyboard-event-constructor.html:
* LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt:

Canonical link: https://commits.webkit.org/273379@main