[webkit-changes] [WebKit/WebKit] 47d87c: Fix layout tests in simulator

Per Arne Vollan noreply at github.com
Tue Jan 23 13:07:13 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47d87cd99fd28559352bec7d539b9a2d0a984121
      https://github.com/WebKit/WebKit/commit/47d87cd99fd28559352bec7d539b9a2d0a984121
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
    M Source/WebKit/Configurations/BaseExtension.xcconfig
    M Source/WebKit/Configurations/BaseXPCService.xcconfig
    M Source/WebKit/Configurations/GPUExtension.xcconfig
    M Source/WebKit/Configurations/GPUService.xcconfig
    M Source/WebKit/Configurations/NetworkService.xcconfig
    M Source/WebKit/Configurations/NetworkingExtension.xcconfig
    M Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig
    M Source/WebKit/Configurations/WebContentExtension.xcconfig
    M Source/WebKit/Configurations/WebContentService.xcconfig
    M Source/WebKit/Scripts/process-entitlements.sh
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtension.entitlements
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements

  Log Message:
  -----------
  Fix layout tests in simulator
rdar://121324669
https://bugs.webkit.org/show_bug.cgi?id=267822

Reviewed by Brent Fulgham.

Fix an issue where the Simulator entitlements are not actually applied. Also use the same bundle ID
for WebKit extensions on Simulator as on device. Additionally, the test runner app needs an extra
entitlement for launching extensions to succeed. This patch changes the bundle IDs for the XPC
services on Simulator where extension based launch is enabled. Otherwise, these bundle IDs will
conflict with the extension bundle IDs.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/GPUExtension.xcconfig:
* Source/WebKit/Configurations/GPUService.xcconfig:
* Source/WebKit/Configurations/NetworkingExtension.xcconfig:
* Source/WebKit/Configurations/NetworkService.xcconfig:
* Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig:
* Source/WebKit/Configurations/WebContentService.xcconfig:
* Source/WebKit/Configurations/WebContentExtension.xcconfig:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:

Canonical link: https://commits.webkit.org/273374@main




More information about the webkit-changes mailing list