[webkit-changes] [WebKit/WebKit] 36de40: AX: AXObjectCache::dirtyIsolatedTreeRelations is c...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36de400f9138812974b62bd16baab486b3a55334
      https://github.com/WebKit/WebKit/commit/36de400f9138812974b62bd16baab486b3a55334
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  AX: AXObjectCache::dirtyIsolatedTreeRelations is called whether relations are modified or not.
https://bugs.webkit.org/show_bug.cgi?id=267875
<rdar://problem/121389682>

Reviewed by Tyler Wilcock.

This causes unnecessary updates to the isolated tree. This patch fixes the issue by making the addRelation and removeRelation method to return a boolean indicating whether the relationships were actually changed.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::updateLabelFor):
(WebCore::AXObjectCache::updateLabeledBy):
(WebCore::AXObjectCache::addRelation):
(WebCore::AXObjectCache::removeAllRelations):
(WebCore::AXObjectCache::removeRelation):
(WebCore::AXObjectCache::updateRelationsForTree):
(WebCore::AXObjectCache::addLabelForRelation):
(WebCore::AXObjectCache::updateRelations):
(WebCore::AXObjectCache::removeRelations): Renamed.
(WebCore::AXObjectCache::addRelations): Renamed.
* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/273341@main