[webkit-changes] [WebKit/WebKit] f67af4: [WebXR] Adjust XRSession visible test

Dan Glastonbury noreply at github.com
Mon Jan 22 18:04:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f67af466054c043a299acea2fefb5ae0da57a534
      https://github.com/WebKit/WebKit/commit/f67af466054c043a299acea2fefb5ae0da57a534
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXRSession.cpp

  Log Message:
  -----------
  [WebXR] Adjust XRSession visible test
https://bugs.webkit.org/show_bug.cgi?id=256938
rdar://problem/109489889

Reviewed by Dean Jackson.

XRVisibilityState is tristate: Visible, VisibleBlurred, Hidden. Previously only
Visible was considered "visible" causing a JS SecurityError to be thrown when
reporting poses in the "blurred" state, ie. when WebXR doesn't have input but
should render.

This change considers both Visible states as "visible" and Hidden as "not
visible".

* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::posesCanBeReported const):

Canonical link: https://commits.webkit.org/273337@main




More information about the webkit-changes mailing list