[webkit-changes] [WebKit/WebKit] bb4042: Variable used to obtain a bit value from mModeFlag...

AtariDreams noreply at github.com
Mon Jan 22 07:29:52 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb40425085b9f49ff6091ce774729aca2db3f1ab
      https://github.com/WebKit/WebKit/commit/bb40425085b9f49ff6091ce774729aca2db3f1ab
  Author: Rose <83477269+AtariDreams at users.noreply.github.com>
  Date:   2024-01-22 (Mon, 22 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm

  Log Message:
  -----------
  Variable used to obtain a bit value from mModeFlags is sign extended
https://bugs.webkit.org/show_bug.cgi?id=263994

Reviewed by Simon Fraser.

mModeFlags is a UInt64, which means we risk overflowing an integer when
we use a signed integer to obtain bit-packed flags from it instead of
using an unsigned long long.

* Source/WebCore/platform/graphics/cocoa/CMUtilities.mm:
(WebCore::PacketDurationParser::framesInPacket): Use an unsigned value
  to obtain the flags stored in mModeFlags.

Canonical link: https://commits.webkit.org/273298@main




More information about the webkit-changes mailing list