[webkit-changes] [WebKit/WebKit] 7c24c6: Make <input type=checkbox switch> iOS-zooming comp...
Anne van Kesteren
noreply at github.com
Mon Jan 22 00:51:47 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7c24c6f0873d402fb1cdd125b3668b2adddc5692
https://github.com/WebKit/WebKit/commit/7c24c6f0873d402fb1cdd125b3668b2adddc5692
Author: Anne van Kesteren <annevk at annevk.nl>
Date: 2024-01-22 (Mon, 22 Jan 2024)
Changed paths:
A LayoutTests/fast/forms/switch/zoom-computed-style-expected.txt
A LayoutTests/fast/forms/switch/zoom-computed-style.html
M Source/WebCore/rendering/RenderThemeIOS.mm
Log Message:
-----------
Make <input type=checkbox switch> iOS-zooming compatible with other ports
https://bugs.webkit.org/show_bug.cgi?id=267757
rdar://121248632
Reviewed by Aditya Keerthi.
This ensures that on iOS builds that can paint a switch, the following
tests pass as expected:
- fast/forms/switch/zoom-approximates-transform-rtl.html
- fast/forms/switch/zoom-approximates-transform-vertical-lr.html
- fast/forms/switch/zoom-approximates-transform-vertical-rl.html
- fast/forms/switch/zoom-approximates-transform.html
Without this fix there would be some amount of zooming on iOS due to it
currently aligning with the font-size, but only for very large zoom
values.
Also add a new test that demonstrates this does not impact
getComputedStyle() across platforms.
* LayoutTests/fast/forms/switch/zoom-computed-style-expected.txt: Added.
* LayoutTests/fast/forms/switch/zoom-computed-style.html: Added.
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustSwitchStyle const):
Canonical link: https://commits.webkit.org/273289@main
More information about the webkit-changes
mailing list