[webkit-changes] [WebKit/WebKit] 410d70: [IFC] Rename InlineLevelBox's annotation to text-e...

Alan Baradlay noreply at github.com
Sun Jan 21 18:23:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 410d70f0b48bae7d9e8dfd0bfa78bad544a3b9fc
      https://github.com/WebKit/WebKit/commit/410d70f0b48bae7d9e8dfd0bfa78bad544a3b9fc
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-21 (Sun, 21 Jan 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp

  Log Message:
  -----------
  [IFC] Rename InlineLevelBox's annotation to text-emphasis
https://bugs.webkit.org/show_bug.cgi?id=267826

Reviewed by Antti Koivisto.

..to not to confuse it with ruby annotation.

* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::hasTextEmphasis const):
(WebCore::Layout::InlineLevelBox::textEmphasisAbove const):
(WebCore::Layout::InlineLevelBox::textEmphasisBelow const):
(WebCore::Layout::InlineLevelBox::hasAnnotation const): Deleted.
(WebCore::Layout::InlineLevelBox::annotationAbove const): Deleted.
(WebCore::Layout::InlineLevelBox::annotationBelow const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
(WebCore::Layout::InlineLevelBox::setTextEmphasis):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::adjustForAnnotationIfNeeded const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::computeInkOverflowForInlineBox):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::collectEnclosingLineGeometry const):

Canonical link: https://commits.webkit.org/273283@main




More information about the webkit-changes mailing list