[webkit-changes] [WebKit/WebKit] 243963: REGRESSION (271261 at main): [ Monterey Ventura Debug...

mattwoodrow noreply at github.com
Sun Jan 21 12:23:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2439631889affe94ff5c0abaa592025f2dcf6c68
      https://github.com/WebKit/WebKit/commit/2439631889affe94ff5c0abaa592025f2dcf6c68
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-01-21 (Sun, 21 Jan 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp

  Log Message:
  -----------
  REGRESSION (271261 at main): [ Monterey Ventura Debug ] ASSERTION FAILED: isValid() in std::unique_ptr<ScrollingStateTree> WebCore::ScrollingStateTree::commit(LayerRepresentation::Type)
https://bugs.webkit.org/show_bug.cgi?id=267655
<rdar://121148828>

Reviewed by Simon Fraser.

ThreadedScrollingCoordinator updates the scrolling tree state at the start of
the rendering update (before rAF callbacks), so that async scrolls can be
performed if the rendering update takes too long.

We need to make sure the compositing layer tree is up to date in order for
this to be valid.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp:
(WebCore::ThreadedScrollingCoordinator::willStartRenderingUpdate):

Canonical link: https://commits.webkit.org/273275@main




More information about the webkit-changes mailing list