[webkit-changes] [WebKit/WebKit] 90f2ba: Make WebKit <input type=checkbox switch> tests iOS...

Anne van Kesteren noreply at github.com
Sat Jan 20 00:38:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90f2bafbe99f4ab1ec05cd05d975c0bbd9aa3ad4
      https://github.com/WebKit/WebKit/commit/90f2bafbe99f4ab1ec05cd05d975c0bbd9aa3ad4
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-20 (Sat, 20 Jan 2024)

  Changed paths:
    M LayoutTests/fast/forms/switch/click-animation-disabled.html
    M LayoutTests/fast/forms/switch/click-animation-interrupted-document-removed.html
    M LayoutTests/fast/forms/switch/click-animation-interrupted-type-change.html
    M LayoutTests/fast/forms/switch/click-animation-interrupted.html
    M LayoutTests/fast/forms/switch/click-animation-preventdefault.html
    M LayoutTests/fast/forms/switch/click-animation-redundant-checked.html
    M LayoutTests/fast/forms/switch/click-animation-redundant-disabled.html
    M LayoutTests/fast/forms/switch/click-animation-twice-fast.html
    M LayoutTests/fast/forms/switch/click-animation-twice.html
    M LayoutTests/fast/forms/switch/click-animation.html
    M LayoutTests/fast/forms/switch/pointer-tracking-disabled.html
    M LayoutTests/fast/forms/switch/pointer-tracking-there-and-back-again-rtl.html
    M LayoutTests/fast/forms/switch/pointer-tracking-there-and-back-again.html
    M LayoutTests/fast/forms/switch/pointer-tracking.html
    M LayoutTests/platform/ios/TestExpectations

  Log Message:
  -----------
  Make WebKit <input type=checkbox switch> tests iOS-compatible
https://bugs.webkit.org/show_bug.cgi?id=267546

Reviewed by Aditya Keerthi.

As there's no public painting code these shall not pass.

The timeout is increased for a number of tests as the tests will
otherwise fail on iOS builds with painting code. That is because iOS
has a separate animation for the switch's thumb that depends on the
pressed state and not the pointer position.

* LayoutTests/fast/forms/switch/click-animation-disabled.html:
* LayoutTests/fast/forms/switch/click-animation-interrupted-document-removed.html:
* LayoutTests/fast/forms/switch/click-animation-interrupted-type-change.html:
* LayoutTests/fast/forms/switch/click-animation-interrupted.html:
* LayoutTests/fast/forms/switch/click-animation-preventdefault.html:
* LayoutTests/fast/forms/switch/click-animation-redundant-checked.html:
* LayoutTests/fast/forms/switch/click-animation-redundant-disabled.html:
* LayoutTests/fast/forms/switch/click-animation-twice-fast.html:
* LayoutTests/fast/forms/switch/click-animation-twice.html:
* LayoutTests/fast/forms/switch/click-animation.html:
* LayoutTests/fast/forms/switch/pointer-tracking-disabled.html:
* LayoutTests/fast/forms/switch/pointer-tracking-there-and-back-again-rtl.html:
* LayoutTests/fast/forms/switch/pointer-tracking-there-and-back-again.html:
* LayoutTests/fast/forms/switch/pointer-tracking.html:
* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/273260@main




More information about the webkit-changes mailing list