[webkit-changes] [WebKit/WebKit] 2dc6a5: [Site isolation] popup opener should be able to na...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2dc6a5e22e986f340194ecee1f3f691286841e1f
      https://github.com/WebKit/WebKit/commit/2dc6a5e22e986f340194ecee1f3f691286841e1f
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  [Site isolation] popup opener should be able to navigate to popup domain
https://bugs.webkit.org/show_bug.cgi?id=267752
rdar://121241095

Reviewed by Charlie Wolfe.

This is the first piece needed to get http/tests/security/frameNavigation/cross-origin-opener.html
running with --site-isolation without crashing.  It turns out we had written a lot of code around
ProvisionalPageProxy::initializeWebPage that only happened if there was an opener, and it needs to
happen sometimes if there isn't an opener.  This is a step towards making that code more robust.
It's not quite there, but it's a step closer than it was and covered by a unit test.

No change in behavior when site isolation is off.

* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame):
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::takeOpenedRemotePageProxyIfDomainEquals):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/273244@main