[webkit-changes] [WebKit/WebKit] 8f9276: AX: Implement off-main-thread AXTextMarkerForIndex...
Tyler Wilcock
noreply at github.com
Fri Jan 19 12:13:58 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8f9276392840002230cdb275b8bb23de2a319d32
https://github.com/WebKit/WebKit/commit/8f9276392840002230cdb275b8bb23de2a319d32
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2024-01-19 (Fri, 19 Jan 2024)
Changed paths:
A LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-index-expected.txt
A LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-index.html
A LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-with-unordered-markers-expected.txt
A LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-with-unordered-markers.html
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AXTextMarker.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: Implement off-main-thread AXTextMarkerForIndexAttribute and AXIndexForTextMarkerAttribute
https://bugs.webkit.org/show_bug.cgi?id=267666
rdar://problem/121157922
Reviewed by Andres Gonzalez.
Also adds two new layout tests with basic coverage for these APIs.
Fixes a bug in AXPreviousTextMarkerForTextMarkerAttribute where AXDirection::Next
was used instead of AXDirection::Previous, which broke test text-marker-range-with-unordered-markers.html.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-index-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-index.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-with-unordered-markers-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-with-unordered-markers.html: Added.
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::hasSameObjectAndOffset const):
(WebCore::AXTextMarker::offsetFromRoot const):
(WebCore::AXTextMarker::nextMarkerFromOffset const):
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Canonical link: https://commits.webkit.org/273234@main
More information about the webkit-changes
mailing list