[webkit-changes] [WebKit/WebKit] 189e40: [WPE] WPE Platform: use weak references to WPEView...

Carlos Garcia Campos noreply at github.com
Fri Jan 19 01:48:40 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 189e402ec1cea8b6d4c01515f2d2ba75fce6df8a
      https://github.com/WebKit/WebKit/commit/189e402ec1cea8b6d4c01515f2d2ba75fce6df8a
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
    M Source/WTF/wtf/glib/GWeakPtr.h
    M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp
    M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.h
    M Tools/TestWebKitAPI/Tests/WTF/glib/GWeakPtr.cpp

  Log Message:
  -----------
  [WPE] WPE Platform: use weak references to WPEView in WPEWaylandSeat
https://bugs.webkit.org/show_bug.cgi?id=267756

Reviewed by Adrian Perez de Castro.

We are leaking the view when pointer leave and keyboard leave are not
emitted. Since GWeakPtr is not copyable, we need to add an explicit move
assignment operator to be able to reset the WPEWaylandSeat structs with
foo = { }.

* Source/WTF/wtf/glib/GWeakPtr.h:
(WTF::GWeakPtr::operator=):
* Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp:
* Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.h:
* Tools/TestWebKitAPI/Tests/WTF/glib/GWeakPtr.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/273215@main




More information about the webkit-changes mailing list