[webkit-changes] [WebKit/WebKit] 9d23c4: [GPU Process] Images with certain colorspaces cann...

Said Abou-Hallawa noreply at github.com
Thu Jan 18 18:02:47 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d23c40ee7ce3c80b6d2b40cc534e78cac079019
      https://github.com/WebKit/WebKit/commit/9d23c40ee7ce3c80b6d2b40cc534e78cac079019
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    A LayoutTests/fast/images/resources/green-100x100-unsupported-output-color-space.jpg
    A LayoutTests/fast/images/unsupported-output-color-space-expected.html
    A LayoutTests/fast/images/unsupported-output-color-space.html
    M Source/WebKit/Shared/ShareableBitmap.cpp
    M Source/WebKit/Shared/ShareableBitmap.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp

  Log Message:
  -----------
  [GPU Process] Images with certain colorspaces cannot be rendered
https://bugs.webkit.org/show_bug.cgi?id=266300
rdar://118238178

Reviewed by Cameron McCormack.

Check if the color space of the NativeImage is supported by CG for output before
creating ShareableBitmap. If it is not supported, fall back to SRGB.

* LayoutTests/fast/images/resources/green-100x100-unsupported-output-color-space.jpg: Added.
* LayoutTests/fast/images/unsupported-output-color-space-expected.html: Added.
* LayoutTests/fast/images/unsupported-output-color-space.html: Added.
* Source/WebKit/Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::createFromImageDraw):
* Source/WebKit/Shared/ShareableBitmap.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::createShareableBitmapFromNativeImage)

Canonical link: https://commits.webkit.org/273204@main




More information about the webkit-changes mailing list