[webkit-changes] [WebKit/WebKit] 83fd54: [WebGPU] shader, validation, parse, attribute, * crash...

mwyrzykowski noreply at github.com
Thu Jan 18 16:52:12 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83fd54401969985f7bb8f5650926298b4bbf142d
      https://github.com/WebKit/WebKit/commit/83fd54401969985f7bb8f5650926298b4bbf142d
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp

  Log Message:
  -----------
  [WebGPU] shader,validation,parse,attribute,* crashes when run
https://bugs.webkit.org/show_bug.cgi?id=267709
<radar://121200436>

Reviewed by Tadeu Zagallo.

constantValue may be std::nullopt, so check its value
prior to continuing.

The shader,validation,parse,attribute:expressions:value=%22override%22;
pass after this change.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
(WGSL::AttributeValidator::parseLocation):

Canonical link: https://commits.webkit.org/273202@main




More information about the webkit-changes mailing list