[webkit-changes] [WebKit/WebKit] da3bbf: Fix role assignment for <header> inside <main> and...

Commit Queue noreply at github.com
Thu Jan 18 11:48:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da3bbf117740b8052a9e28fe42d9f6aadd283c56
      https://github.com/WebKit/WebKit/commit/da3bbf117740b8052a9e28fe42d9f6aadd283c56
  Author: Joone Hur <joone at webkit.org>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M LayoutTests/accessibility/mac/html-section-elements-expected.txt
    M LayoutTests/accessibility/mac/html-section-elements.html
    M LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  Fix role assignment for <header> inside <main> and sectioning elements
https://bugs.webkit.org/show_bug.cgi?id=242685
<rdar://48370244>

Reviewed by Tyler Wilcock.

This change assigns a generic role to <header> elements when nested
within <main>, <aside>, <article>, <section>, or <nav> elements, aligning with
the W3C spec(https://w3c.github.io/html-aam/#el-header)

Previously, the <main> element was not included in these conditions.
The <header> element assumed an unknown role instead of a generic role in these
conditions.

* LayoutTests/accessibility/mac/html-section-elements-expected.txt:
* LayoutTests/accessibility/mac/html-section-elements.html:
* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):

Canonical link: https://commits.webkit.org/273188@main




More information about the webkit-changes mailing list