[webkit-changes] [WebKit/WebKit] 5556d4: [iOS] Returning to fullscreen to PiP on YouTube br...

Jer Noble noreply at github.com
Thu Jan 18 08:51:36 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5556d4cf108f655932abdbd7004b40578588b5d4
      https://github.com/WebKit/WebKit/commit/5556d4cf108f655932abdbd7004b40578588b5d4
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

  Log Message:
  -----------
  [iOS] Returning to fullscreen to PiP on YouTube breaks subsequent touch input
https://bugs.webkit.org/show_bug.cgi?id=267674
rdar://119832557

Reviewed by Eric Carlson.

When returning to Element Fullscreen from PiP, the normal "exit picture-in-picture" logic
is interrupted in order to restore the previous element fullscreen. Recent changes have
left the video fullscreen state machine broken, waiting to restore the video to its original
location. The WKFullscreenViewController is left in place, but empty, either atop the WKWebView,
or below it but containing the video layer.

When we receive the preparedToReturnToStandby(), instead of just clearing the PiP fullscreen
mode, continue processing the steps of the "exit picture-in-picture" logic at the point at
which it was interrupted.

* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::preparedToReturnToStandby):
(VideoFullscreenInterfaceAVKit::returnToStandby):

Canonical link: https://commits.webkit.org/273180@main




More information about the webkit-changes mailing list