[webkit-changes] [WebKit/WebKit] d86fef: [WGSL] shader, execution, zero_init:* is failing

Tadeu Zagallo noreply at github.com
Thu Jan 18 05:38:41 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d86fef64a7c356724248608496d68f3f8f27044a
      https://github.com/WebKit/WebKit/commit/d86fef64a7c356724248608496d68f3f8f27044a
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTCallExpression.h
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WGSL] shader,execution,zero_init:* is failing
https://bugs.webkit.org/show_bug.cgi?id=267646
rdar://121134298

Reviewed by Mike Wyrzykowski.

Arrays and structs in the workgroup/threadgroup address space also need to be
explicitly initialized.

* Source/WebGPU/WGSL/AST/ASTCallExpression.h:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertLocalDefinitions):
(WGSL::RewriteGlobalVariables::initializeVariables):
(WGSL::RewriteGlobalVariables::storeInitialValue):
(WGSL::RewriteGlobalVariables::initializeAtomics): Deleted.
(WGSL::RewriteGlobalVariables::atomicStoreInitialValue): Deleted.
(WGSL::RewriteGlobalVariables::containsAtomic): Deleted.

Canonical link: https://commits.webkit.org/273176@main




More information about the webkit-changes mailing list