[webkit-changes] [WebKit/WebKit] 170161: [web-animations] rename DeclarativeAnimation to St...

Antoine Quint noreply at github.com
Thu Jan 18 00:33:17 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1701618d04c4680a58da33544f9a349daacd1186
      https://github.com/WebKit/WebKit/commit/1701618d04c4680a58da33544f9a349daacd1186
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/AnimationEffect.cpp
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/CSSAnimation.h
    M Source/WebCore/animation/CSSAnimationEvent.cpp
    M Source/WebCore/animation/CSSAnimationEvent.h
    M Source/WebCore/animation/CSSTransition.cpp
    M Source/WebCore/animation/CSSTransition.h
    M Source/WebCore/animation/CSSTransitionEvent.cpp
    M Source/WebCore/animation/CSSTransitionEvent.h
    R Source/WebCore/animation/DeclarativeAnimation.cpp
    R Source/WebCore/animation/DeclarativeAnimation.h
    R Source/WebCore/animation/DeclarativeAnimationEvent.cpp
    R Source/WebCore/animation/DeclarativeAnimationEvent.h
    M Source/WebCore/animation/DocumentTimeline.cpp
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    A Source/WebCore/animation/StyleOriginatedAnimation.cpp
    A Source/WebCore/animation/StyleOriginatedAnimation.h
    A Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp
    A Source/WebCore/animation/StyleOriginatedAnimationEvent.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/dom/ContentVisibilityDocumentState.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
    M Source/WebCore/inspector/agents/InspectorAnimationAgent.h
    M Source/WebCore/platform/animation/AcceleratedEffect.cpp
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
    M Source/WebCore/style/Styleable.cpp
    M Source/WebCore/style/Styleable.h

  Log Message:
  -----------
  [web-animations] rename DeclarativeAnimation to StyleOriginatedAnimation
https://bugs.webkit.org/show_bug.cgi?id=267640
rdar://121121419

Reviewed by Ryosuke Niwa.

Animations originated from CSS, CSS Animations and CSS Transitions, share a superclass named `DeclarativeAnimation`.
However, the terminology is "style-originated animation" as opposed to "script-originated animation". We rename
that shared superclass to reflect this.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::getBindingsTiming const):
(WebCore::AnimationEffect::getBindingsComputedTiming const):
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::CSSAnimation):
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::bindingsPlay):
(WebCore::CSSAnimation::bindingsPause):
(WebCore::CSSAnimation::setBindingsEffect):
(WebCore::CSSAnimation::setBindingsStartTime):
(WebCore::CSSAnimation::bindingsReverse):
(WebCore::CSSAnimation::updateKeyframesIfNeeded):
(WebCore::CSSAnimation::createEvent):
* Source/WebCore/animation/CSSAnimation.h:
* Source/WebCore/animation/CSSAnimationEvent.cpp:
(WebCore::CSSAnimationEvent::CSSAnimationEvent):
* Source/WebCore/animation/CSSAnimationEvent.h:
* Source/WebCore/animation/CSSTransition.cpp:
(WebCore::CSSTransition::CSSTransition):
(WebCore::CSSTransition::resolve):
(WebCore::CSSTransition::animationDidFinish):
(WebCore::CSSTransition::createEvent):
* Source/WebCore/animation/CSSTransition.h:
* Source/WebCore/animation/CSSTransitionEvent.cpp:
(WebCore::CSSTransitionEvent::CSSTransitionEvent):
* Source/WebCore/animation/CSSTransitionEvent.h:
* Source/WebCore/animation/DocumentTimeline.cpp:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):
(WebCore::KeyframeEffect::computeStyleOriginatedAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::timingFunctionForBlendingKeyframe const):
(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):
(WebCore::KeyframeEffect::bindingsComposite const):
(WebCore::KeyframeEffect::computeDeclarativeAnimationBlendingKeyframes): Deleted.
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/StyleOriginatedAnimation.cpp: Renamed from Source/WebCore/animation/DeclarativeAnimation.cpp.
(WebCore::StyleOriginatedAnimation::StyleOriginatedAnimation):
(WebCore::StyleOriginatedAnimation::~StyleOriginatedAnimation):
(WebCore::StyleOriginatedAnimation::owningElement const):
(WebCore::StyleOriginatedAnimation::tick):
(WebCore::StyleOriginatedAnimation::canHaveGlobalPosition):
(WebCore::StyleOriginatedAnimation::disassociateFromOwningElement):
(WebCore::StyleOriginatedAnimation::setBackingAnimation):
(WebCore::StyleOriginatedAnimation::initialize):
(WebCore::StyleOriginatedAnimation::syncPropertiesWithBackingAnimation):
(WebCore::StyleOriginatedAnimation::bindingsStartTime const):
(WebCore::StyleOriginatedAnimation::bindingsCurrentTime const):
(WebCore::StyleOriginatedAnimation::bindingsPlayState const):
(WebCore::StyleOriginatedAnimation::bindingsReplaceState const):
(WebCore::StyleOriginatedAnimation::bindingsPending const):
(WebCore::StyleOriginatedAnimation::bindingsReady):
(WebCore::StyleOriginatedAnimation::bindingsFinished):
(WebCore::StyleOriginatedAnimation::bindingsPlay):
(WebCore::StyleOriginatedAnimation::bindingsPause):
(WebCore::StyleOriginatedAnimation::flushPendingStyleChanges const):
(WebCore::StyleOriginatedAnimation::setTimeline):
(WebCore::StyleOriginatedAnimation::cancel):
(WebCore::StyleOriginatedAnimation::cancelFromStyle):
(WebCore::StyleOriginatedAnimation::phaseWithoutEffect const):
(WebCore::StyleOriginatedAnimation::effectTimeAtStart const):
(WebCore::StyleOriginatedAnimation::effectTimeAtIteration const):
(WebCore::StyleOriginatedAnimation::effectTimeAtEnd const):
(WebCore::StyleOriginatedAnimation::shouldFireDOMEvents const):
(WebCore::StyleOriginatedAnimation::invalidateDOMEvents):
(WebCore::StyleOriginatedAnimation::enqueueDOMEvent):
* Source/WebCore/animation/StyleOriginatedAnimation.h: Renamed from Source/WebCore/animation/DeclarativeAnimation.h.
(WebCore::StyleOriginatedAnimation::backingAnimation const):
* Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp: Renamed from Source/WebCore/animation/DeclarativeAnimationEvent.cpp.
(WebCore::StyleOriginatedAnimationEvent::StyleOriginatedAnimationEvent):
(WebCore::StyleOriginatedAnimationEvent::pseudoElement):
* Source/WebCore/animation/StyleOriginatedAnimationEvent.h: Renamed from Source/WebCore/animation/DeclarativeAnimationEvent.h.
(WebCore::StyleOriginatedAnimationEvent::elapsedTime const):
(WebCore::StyleOriginatedAnimationEvent::pseudoId const):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::isReplaceable const):
(WebCore::WebAnimation::isSkippedContentAnimation const):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::isStyleOriginatedAnimation const):
(WebCore::WebAnimation::isDeclarativeAnimation const): Deleted.
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::compareStyleOriginatedAnimationOwningElementPositionsInDocumentTreeOrder):
(WebCore::compareCSSTransitions):
(WebCore::compareCSSAnimations):
(WebCore::compareAnimationsByCompositeOrder):
(WebCore::compareStyleOriginatedAnimationEvents):
(WebCore::compareAnimationEventsByCompositeOrder):
(WebCore::compareDeclarativeAnimationOwningElementPositionsInDocumentTreeOrder): Deleted.
(WebCore::compareDeclarativeAnimationEvents): Deleted.
* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:
(WebCore::ContentVisibilityDocumentState::updateAnimations):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::removeFromTopLayer):
* Source/WebCore/inspector/InspectorInstrumentation.h:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::buildObjectForKeyframes):
(WebCore::InspectorAnimationAgent::startTracking):
(WebCore::InspectorAnimationAgent::stopTracking):
(WebCore::InspectorAnimationAgent::willApplyKeyframeEffect):
(WebCore::InspectorAnimationAgent::didSetWebAnimationEffect):
(WebCore::InspectorAnimationAgent::willDestroyWebAnimation):
(WebCore::InspectorAnimationAgent::stopTrackingStyleOriginatedAnimation):
(WebCore::InspectorAnimationAgent::stopTrackingDeclarativeAnimation): Deleted.
* Source/WebCore/inspector/agents/InspectorAnimationAgent.h:
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::AcceleratedEffect::AcceleratedEffect):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::removeStyleOriginatedAnimationFromListsForOwningElement const):
(WebCore::Styleable::animationWasRemoved const):
(WebCore::Styleable::elementWasRemoved const):
(WebCore::Styleable::cancelStyleOriginatedAnimations const):
(WebCore::updateCSSTransitionsForStyleableAndProperty):
(WebCore::Styleable::removeDeclarativeAnimationFromListsForOwningElement const): Deleted.
(WebCore::Styleable::cancelDeclarativeAnimations const): Deleted.
* Source/WebCore/style/Styleable.h:

Canonical link: https://commits.webkit.org/273170@main

More information about the webkit-changes mailing list