[webkit-changes] [WebKit/WebKit] 303358: [WebGPU] api, validation, resource_usages, * is failing

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 303358b88d2fee46d19d37a5b58a46a7113e5ac6
      https://github.com/WebKit/WebKit/commit/303358b88d2fee46d19d37a5b58a46a7113e5ac6
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/buffer/in_pass_encoder-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/buffer/in_pass_encoder.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/buffer/in_pass_misc-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/buffer/in_pass_misc.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_pass_encoder-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_pass_encoder.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_common-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_common.spec.js
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_misc-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_misc.spec.js
    M Source/WebGPU/WGSL/TypeDeclarations.rb
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/BindableResource.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.h
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderBundle.h
    M Source/WebGPU/WebGPU/RenderBundle.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] api,validation,resource_usages,* is failing
https://bugs.webkit.org/show_bug.cgi?id=267280
<radar://120725505>

Reviewed by Dan Glastonbury.

Add passing expectations for the five subsuites under resource_usages and add
validation to conform to the specification.

Also update the tests to the latest version of the CTS which matches the latest
version of the specification.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/buffer/in_pass_encoder-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/buffer/in_pass_encoder.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_pass_encoder-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_pass_encoder.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_common-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_common.spec.js:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_misc-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/resource_usages/texture/in_render_misc.spec.js:

* Source/WebGPU/WGSL/TypeDeclarations.rb:
Add textureLoad declarations for 2d storage textures, 2d arrays, and 3d storage textures.

* Source/WebGPU/WebGPU/BindGroup.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::metalRenderStage):
(WebGPU::formatType):
(WebGPU::formatIsFloat):
(WebGPU::formatIsUnfilterableFloat):
(WebGPU::formatIsDepth):
(WebGPU::formatIsSignedInt):
(WebGPU::formatIsUnsignedInt):
(WebGPU::validateTextureSampleType):
(WebGPU::usageForTexture):
(WebGPU::usageForStorageTexture):
(WebGPU::usageForBuffer):
(WebGPU::makeBindGroupEntryUsageData):
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::allowedUsage):
(WebGPU::BindGroup::makeEntryMapKey):
* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::encodedLength const):
(WebGPU::BindGroupLayout::argumentBufferIndexForEntryIndex const):
(WebGPU::BindGroupLayout::bufferSizeIndexForEntryIndex const):
* Source/WebGPU/WebGPU/BindableResource.h:
(WebGPU::isTextureBindGroupEntryUsage):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::addResourceToActiveResources):
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
(WebGPU::ComputePassEncoder::dispatchIndirect):
(WebGPU::ComputePassEncoder::setBindGroup):
* Source/WebGPU/WebGPU/RenderBundle.h:
* Source/WebGPU/WebGPU/RenderBundle.mm:
(-[ResourceUsageAndRenderStage initWithUsage:renderStages:entryUsage:binding:]):
(-[ResourceUsageAndRenderStage initWithUsage:renderStages:]): Deleted.
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::makeRenderBundleICBWithResources):
(WebGPU::RenderBundleEncoder::addResource):
(WebGPU::RenderBundleEncoder::setBindGroup):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::addResourceToActiveResources):
(WebGPU::RenderPassEncoder::validateBindGroups):
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::drawIndexedIndirect):
(WebGPU::RenderPassEncoder::drawIndirect):
(WebGPU::RenderPassEncoder::endPass):
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::setBindGroup):
(WebGPU::RenderPassEncoder::setIndexBuffer):
(WebGPU::RenderPassEncoder::setVertexBuffer):

Canonical link: https://commits.webkit.org/273152@main