[webkit-changes] [WebKit/WebKit] 90be7b: Address post review comments for <https://commits....

Per Arne Vollan noreply at github.com
Wed Jan 17 13:54:36 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90be7bc36004417e260f4f666c6411ad1591a6ff
      https://github.com/WebKit/WebKit/commit/90be7bc36004417e260f4f666c6411ad1591a6ff
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.mm
    M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm
    M Source/WebKit/Platform/cocoa/LayerHostingContext.h
    M Source/WebKit/Platform/cocoa/LayerHostingContext.mm
    M Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h
    M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm

  Log Message:
  -----------
  Address post review comments for <https://commits.webkit.org/272703@main>
https://bugs.webkit.org/show_bug.cgi?id=267275
rdar://120867428

Reviewed by Jer Noble and Brent Fulgham.

This patch is addressing post review comments for <https://commits.webkit.org/272703@main>. It also makes
sure that commit is called on the update coordinator in the UI process right after the message is sent
to the WebContent process to update the layer size.

Additionally, this patch addresses an issue where we did not update the hosting handle in the UI process
when the context ID changed. This issue would stop video rendering in certain cases.

* Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.mm:
(WebCore::VideoPresentationModelVideoElement::setVideoSizeFenced):
* Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::setVideoLayerSizeFenced):
* Source/WebKit/Platform/cocoa/LayerHostingContext.h:
(WebKit::LayerHostingContext::hostable const):
* Source/WebKit/Platform/cocoa/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForExternalHostingProcess):
(WebKit::LayerHostingContext::~LayerHostingContext):
(WebKit::LayerHostingContext::contextID const):
(WebKit::LayerHostingContext::setFencePort):
(WebKit::LayerHostingContext::createHostingUpdateCoordinator):
(WebKit::LayerHostingContext::createHostingHandle):
(WebKit::LayerHostingContext::commit): Deleted.
* Source/WebKit/Platform/spi/Cocoa/ExtensionKitSPI.h:
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::createLayerHostViewWithID):
(WebKit::VideoPresentationManagerProxy::setVideoLayerFrame):
(-[WKLayerHostView dealloc]): Deleted.

Canonical link: https://commits.webkit.org/273143@main




More information about the webkit-changes mailing list