[webkit-changes] [WebKit/WebKit] 3a032c: AX: Add AccessibilityThreadTextApisEnabled flag an...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a032c58f74b524e32d621784defac5a14a8d81a
      https://github.com/WebKit/WebKit/commit/3a032c58f74b524e32d621784defac5a14a8d81a
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    A LayoutTests/accessibility/ax-thread-text-apis/character-offset-from-upstream-position-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/character-offset-from-upstream-position.html
    A LayoutTests/accessibility/ax-thread-text-apis/content-editable-attributed-string-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/content-editable-attributed-string.html
    A LayoutTests/accessibility/ax-thread-text-apis/element-for-text-marker-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/element-for-text-marker.html
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-bounds-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-bounds.html
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-length-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-length.html
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-empty-contenteditable-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-empty-contenteditable.html
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-with-user-select-none-expected.txt
    A LayoutTests/accessibility/ax-thread-text-apis/text-marker-with-user-select-none.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Add AccessibilityThreadTextApisEnabled flag and hook it up to several APIs
https://bugs.webkit.org/show_bug.cgi?id=267477
rdar://problem/120928163

Reviewed by Chris Fleizach and Andres Gonzalez.

This patch also adds a mechanism for testing this configuration, and adds 7 tests.

* LayoutTests/TestExpectations: Skip ax-thread-text-apis/ tests by default.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/ax-thread-text-apis/character-offset-from-upstream-position-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/character-offset-from-upstream-position.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/content-editable-attributed-string-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/content-editable-attributed-string.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/element-for-text-marker-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/element-for-text-marker.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-bounds-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-for-bounds.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-length-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-length.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-empty-contenteditable-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-for-empty-contenteditable.html: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-with-user-select-none-expected.txt: Added.
* LayoutTests/accessibility/ax-thread-text-apis/text-marker-with-user-select-none.html: Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
* Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::accessibilityThreadTextApisEnabled):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::findMarker const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Canonical link: https://commits.webkit.org/273130@main