[webkit-changes] [WebKit/WebKit] b30ec2: "Turn off the lights" extension service worker fai...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b30ec2ac54474e2b9e82e0cc5bbf1b6abd7821f9
      https://github.com/WebKit/WebKit/commit/b30ec2ac54474e2b9e82e0cc5bbf1b6abd7821f9
  Author: Kiara Rose <kiara_rose at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm

  Log Message:
  -----------
  "Turn off the lights" extension service worker fails to load.
https://bugs.webkit.org/show_bug.cgi?id=267590
rdar://120864698

Reviewed by Timothy Hatcher.

Turn off the light's service worker fails to load because we incorrectly throw an error for empty
titles when context menus of type "separator" are created. We should update the check to allow for
empty titles for type 'separator'. We should also remove the checks that prevent 'command', 'onclick',
'icons', 'checked', and 'enabled' from being specified if the type is 'separator' since that isn't
specified in the Chrome or MDN documentation.

Testing:
TOTL extension works as expected.

* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm:
(WebKit::WebExtensionAPIMenus::parseCreateAndUpdateProperties):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/273128@main