[webkit-changes] [WebKit/WebKit] 29b480: incorrect repaint area for underline text decorations

Alan Baradlay noreply at github.com
Wed Jan 17 06:55:22 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29b480f1c8349093107d04519874a4603cfc50f7
      https://github.com/WebKit/WebKit/commit/29b480f1c8349093107d04519874a4603cfc50f7
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    A LayoutTests/fast/repaint/text-decoration-underline-repaint-expected.txt
    A LayoutTests/fast/repaint/text-decoration-underline-repaint.html
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp

  Log Message:
  -----------
  incorrect repaint area for underline text decorations
https://bugs.webkit.org/show_bug.cgi?id=267568

Reviewed by Antti Koivisto.

Text decoration style (thickness etc) is on the parent inline box (or block container) and not on the text box's style.

* LayoutTests/fast/repaint/text-decoration-underline-repaint-expected.txt: Added.
* LayoutTests/fast/repaint/text-decoration-underline-repaint.html: Added.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::collectInkOverflowForTextDecorations):

Canonical link: https://commits.webkit.org/273126@main




More information about the webkit-changes mailing list