[webkit-changes] [WebKit/WebKit] 0d838e: [WebGPU] api/validation/render_pass/attachment_com...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d838e275b555f5f9d02f4fabc5cd976fa395005
      https://github.com/WebKit/WebKit/commit/0d838e275b555f5f9d02f4fabc5cd976fa395005
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-01-17 (Wed, 17 Jan 2024)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pass/attachment_compatibility-expected.txt
    M Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h
    M Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.idl
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/RenderBundle.h
    M Source/WebGPU/WebGPU/RenderBundle.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/TextureView.h
    M Source/WebGPU/WebGPU/TextureView.mm
    M Source/WebGPU/WebGPU/WebGPU.h
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.cpp
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.h
    M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.serialization.in

  Log Message:
  -----------
  [WebGPU] api/validation/render_pass/attachment_compatibility is failing
https://bugs.webkit.org/show_bug.cgi?id=267023
<radar://120400033>

Reviewed by Dan Glastonbury.

All of api/validation/render_pass/* is passing now.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/render_pass/attachment_compatibility-expected.txt:
Add passing expectations.

* Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h:
(WebCore::GPURenderPassColorAttachment::convertToBacking const):
* Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.idl:
depthSlice was added two days ago, need to add it to have all render_pass/* CTS tests pass.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp:
(WebCore::WebGPU::CommandEncoderImpl::beginRenderPass):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::create):
(WebGPU::RenderBundle::isValid const): Deleted.
* Source/WebGPU/WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::RenderBundle):
(WebGPU::RenderBundle::isValid const):
(WebGPU::RenderBundle::replayCommands const):
(WebGPU::RenderBundle::validateRenderPass const):
(WebGPU::RenderBundle::validatePipeline):
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
(WebGPU::RenderBundleEncoder::create):
(WebGPU::RenderBundleEncoder::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(-[RenderBundleICBWithResources initWithICB:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:fragmentDynamicOffsetsBuffer:pipeline:]):
(WebGPU::makeRenderBundleICBWithResources):
(WebGPU::Device::createRenderBundleEncoder):
(WebGPU::RenderBundleEncoder::RenderBundleEncoder):
(WebGPU::RenderBundleEncoder::makeInvalid):
(WebGPU::RenderBundleEncoder::currentRenderCommand):
(WebGPU::RenderBundleEncoder::addResource):
(WebGPU::RenderBundleEncoder::drawIndexedIndirect):
(WebGPU::RenderBundleEncoder::drawIndirect):
(WebGPU::RenderBundleEncoder::endCurrentICB):
(WebGPU::RenderBundleEncoder::finish):
(WebGPU::RenderBundleEncoder::replayCommands):
(WebGPU::RenderBundleEncoder::icbNeedsToBeSplit):
(WebGPU::RenderBundleEncoder::setPipeline):
(-[RenderBundleICBWithResources initWithICB:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:fragmentDynamicOffsetsBuffer:]): Deleted.
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::create):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::endPass):
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::colorDepthStencilTargetsMatch const):
(WebGPU::RenderPassEncoder::renderCommandEncoder const):
(WebGPU::RenderPassEncoder::makeInvalid):
(WebGPU::RenderPassEncoder::setPipeline):
* Source/WebGPU/WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::RenderPipeline::RenderPipeline):
(WebGPU::RenderPipeline::writesDepth const):
(WebGPU::RenderPipeline::writesStencil const):
(WebGPU::RenderPipeline::validateDepthStencilState const):
(WebGPU::RenderPipeline::colorDepthStencilTargetsMatch const):
(WebGPU::RenderPipeline::validateRenderBundle const):
(WebGPU::RenderPipeline::colorTargetsMatch const): Deleted.
(WebGPU::RenderPipeline::depthAttachmentMatches const): Deleted.
(WebGPU::RenderPipeline::stencilAttachmentMatches const): Deleted.
* Source/WebGPU/WebGPU/TextureView.h:
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::depthOrArrayLayers const):
* Source/WebGPU/WebGPU/WebGPU.h:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.cpp:
(WebKit::WebGPU::ConvertToBackingContext::convertToBacking):
(WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking):
* Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.h:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.serialization.in:

Canonical link: https://commits.webkit.org/273120@main