[webkit-changes] [WebKit/WebKit] a945ee: Disable building XPC services when launching WebKi...

Per Arne Vollan noreply at github.com
Tue Jan 16 21:40:53 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a945ee0ce3091b1884cf601b894ebc9a8d776320
      https://github.com/WebKit/WebKit/commit/a945ee0ce3091b1884cf601b894ebc9a8d776320
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M Source/WebKit/Configurations/BaseExtension.xcconfig
    M Source/WebKit/Configurations/GPUExtension.xcconfig
    M Source/WebKit/Configurations/NetworkingExtension.xcconfig
    M Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig
    M Source/WebKit/Configurations/WebContentExtension.xcconfig
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUExtension-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingExtension-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-CaptivePortal-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Info.plist
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Disable building XPC services when launching WebKit processes as extensions
https://bugs.webkit.org/show_bug.cgi?id=267248
rdar://120677588

Reviewed by Elliot Williams, Brent Fulgham and Timothy Hatcher.

Disable building XPC services when launching WebKit processes as extensions. Additonally, this patch
is changing the bundle ID of the extensions to match the XPC service bundle IDs. This is to ensure
that existing bundle ID checks will continue to work. Also disable fallback to XPC service launch,
since these are not being built anymore. Instead, add a temporary fallback using the old extension
bundle IDs, since they may be cached on the system.

This patch is relanding https://commits.webkit.org/272887@main and
https://commits.webkit.org/272868@main.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/GPUExtension.xcconfig:
* Source/WebKit/Configurations/GPUService.xcconfig:
* Source/WebKit/Configurations/NetworkService.xcconfig:
* Source/WebKit/Configurations/NetworkingExtension.xcconfig:
* Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig:
* Source/WebKit/Configurations/WebContentExtension.xcconfig:
* Source/WebKit/Configurations/WebContentService.xcconfig:
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
(WebKit::ProcessLauncher::setIsRetryingLaunch):
(WebKit::ProcessLauncher::isRetryingLaunch const):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::serviceNameAndIdentifier):
(WebKit::launchWithExtensionKit):
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/273113@main




More information about the webkit-changes mailing list