[webkit-changes] [WebKit/WebKit] b4a042: Store fewer raw pointers in containers in renderin...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4a04231c20afc7a2800c446dd3d7ece452b6022
      https://github.com/WebKit/WebKit/commit/b4a04231c20afc7a2800c446dd3d7ece452b6022
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/rendering/FloatingObjects.cpp
    M Source/WebCore/rendering/FloatingObjects.h
    M Source/WebCore/rendering/Grid.cpp
    M Source/WebCore/rendering/Grid.h
    M Source/WebCore/rendering/GridMasonryLayout.cpp
    M Source/WebCore/rendering/GridMasonryLayout.h
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
    M Source/WebCore/rendering/ImageQualityController.cpp
    M Source/WebCore/rendering/ImageQualityController.h
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h
    M Source/WebCore/rendering/RenderFragmentContainer.cpp
    M Source/WebCore/rendering/RenderFragmentContainer.h
    M Source/WebCore/rendering/RenderFragmentedFlow.cpp
    M Source/WebCore/rendering/RenderFragmentedFlow.h
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderTable.cpp
    M Source/WebCore/rendering/RenderTableSection.cpp
    M Source/WebCore/rendering/svg/RenderSVGRoot.cpp

  Log Message:
  -----------
  Store fewer raw pointers in containers in rendering code
https://bugs.webkit.org/show_bug.cgi?id=267513

Reviewed by Brent Fulgham.

This tested as performance neutral on the benchmarks we track.

* Source/WebCore/rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::moveAllToFloatInfoMap):
* Source/WebCore/rendering/FloatingObjects.h:
* Source/WebCore/rendering/Grid.cpp:
(WebCore::Grid::gridItemArea const):
(WebCore::Grid::setGridItemArea):
* Source/WebCore/rendering/Grid.h:
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::updateItemOffset):
(WebCore::GridMasonryLayout::offsetForChild const):
* Source/WebCore/rendering/GridMasonryLayout.h:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::cacheBaselineAlignedItem):
(WebCore::GridTrackSizingAlgorithm::computeBaselineAlignmentContext):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
* Source/WebCore/rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::set):
* Source/WebCore/rendering/ImageQualityController.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::getBlockRareData):
(WebCore::ensureBlockRareData):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hasOverridingLogicalHeight const):
(WebCore::RenderBox::hasOverridingLogicalWidth const):
(WebCore::RenderBox::setOverridingLogicalHeight):
(WebCore::RenderBox::setOverridingLogicalWidth):
(WebCore::RenderBox::clearOverridingLogicalHeight):
(WebCore::RenderBox::clearOverridingLogicalWidth):
(WebCore::RenderBox::overridingLogicalWidth const):
(WebCore::RenderBox::overridingLogicalHeight const):
(WebCore::RenderBox::overridingContainingBlockContentWidth const):
(WebCore::RenderBox::overridingContainingBlockContentHeight const):
(WebCore::RenderBox::hasOverridingContainingBlockContentWidth const):
(WebCore::RenderBox::hasOverridingContainingBlockContentHeight const):
(WebCore::RenderBox::overridingContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::overridingContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::hasOverridingContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::hasOverridingContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::setOverridingContainingBlockContentLogicalWidth):
(WebCore::RenderBox::setOverridingContainingBlockContentLogicalHeight):
(WebCore::RenderBox::clearOverridingContainingBlockContentSize):
(WebCore::RenderBox::clearOverridingContainingBlockContentLogicalHeight):
(WebCore::RenderBox::overridingLogicalHeightLength const):
(WebCore::RenderBox::setOverridingLogicalHeightLength):
(WebCore::RenderBox::hasOverridingLogicalHeightLength const):
(WebCore::RenderBox::clearOverridingLogicalHeightLength):
(WebCore::RenderBox::overridingLogicalWidthLength const):
(WebCore::RenderBox::setOverridingLogicalWidthLength):
(WebCore::RenderBox::hasOverridingLogicalWidthLength const):
(WebCore::RenderBox::clearOverridingLogicalWidthLength):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::continuation const):
(WebCore::RenderBoxModelObject::inlineContinuation const):
(WebCore::RenderBoxModelObject::forRendererAndContinuations):
(WebCore::RenderBoxModelObject::continuationChainNode const):
(WebCore::RenderBoxModelObject::insertIntoContinuationChainAfter):
(WebCore::RenderBoxModelObject::removeFromContinuationChain):
(WebCore::RenderBoxModelObject::ensureContinuationChainNode):
(WebCore::RenderBoxModelObject::firstLetterRemainingText const):
(WebCore::RenderBoxModelObject::setFirstLetterRemainingText):
(WebCore::RenderBoxModelObject::clearFirstLetterRemainingText):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::cachedChildIntrinsicContentLogicalHeight const):
(WebCore::RenderFlexibleBox::setCachedChildIntrinsicContentLogicalHeight):
(WebCore::RenderFlexibleBox::clearCachedChildIntrinsicContentLogicalHeight):
(WebCore::RenderFlexibleBox::cacheChildMainSize):
(WebCore::RenderFlexibleBox::clearCachedMainSizeForChild):
(WebCore::RenderFlexibleBox::computeFlexBaseSizeForChild):
(WebCore::RenderFlexibleBox::maybeCacheChildMainIntrinsicSize):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::renderBoxFragmentInfo const):
(WebCore::RenderFragmentContainer::setRenderBoxFragmentInfo):
(WebCore::RenderFragmentContainer::takeRenderBoxFragmentInfo):
(WebCore::RenderFragmentContainer::removeRenderBoxFragmentInfo):
* Source/WebCore/rendering/RenderFragmentContainer.h:

Canonical link: https://commits.webkit.org/273101@main