[webkit-changes] [WebKit/WebKit] a6b409: [ApplePay] toDecimalNumber() implementation should...

Abrar Rahman Protyasha noreply at github.com
Tue Jan 16 10:58:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6b409d73485591bc5f0f89698cd5e3e1dcb71a1
      https://github.com/WebKit/WebKit/commit/a6b409d73485591bc5f0f89698cd5e3e1dcb71a1
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm
    M Source/WebCore/Modules/applepay/PaymentSummaryItems.h
    M Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm
    M Source/WebKit/Shared/ApplePay/cocoa/PaymentTokenContextCocoa.mm
    M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h
    M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm

  Log Message:
  -----------
  [ApplePay] toDecimalNumber() implementation should be shared
https://bugs.webkit.org/show_bug.cgi?id=267501
rdar://120952367

Reviewed by Wenson Hsieh.

This commit unifies three identical definitions of `toDecimalNumber()`
across the codebase into a single free-function in the WebCore
namespace, declared in PaymentSummaryItems.h, where it is primarily
used (and was introduced).

* Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm:
(WebCore::toDecimalNumber): Deleted.
* Source/WebCore/Modules/applepay/PaymentSummaryItems.h:
* Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm:
(WebCore::toDecimalNumber):
* Source/WebKit/Shared/ApplePay/cocoa/PaymentTokenContextCocoa.mm:
(WebKit::platformPaymentTokenContext):
* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKShippingMethod):
(WebKit::toDecimalNumber): Deleted.

Canonical link: https://commits.webkit.org/273079@main




More information about the webkit-changes mailing list