[webkit-changes] [WebKit/WebKit] 6714bd: [LFC] Remove unused struct Edges/HorizontalEdges/V...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6714bdd7da7b027e4ded35189d748075161b5579
      https://github.com/WebKit/WebKit/commit/6714bdd7da7b027e4ded35189d748075161b5579
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M Source/WebCore/layout/LayoutUnits.h
    M Source/WebCore/layout/floats/FloatAvoider.cpp
    M Source/WebCore/layout/floats/FloatAvoider.h
    M Source/WebCore/layout/floats/FloatingContext.cpp
    M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/FormattingGeometry.h
    M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexRect.h
    M Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.h
    M Source/WebCore/layout/formattingContexts/table/TableGrid.h
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [LFC] Remove unused struct Edges/HorizontalEdges/VerticalEdges
https://bugs.webkit.org/show_bug.cgi?id=267565

Reviewed by Antti Koivisto.

Transition rest of the layout code to BoxGeometry's edge and remove LFC "global" Edges structure.
(Also add a Flex specific main/cross axis margin structure)

* Source/WebCore/layout/LayoutUnits.h:
(WebCore::Layout::Edges::width const): Deleted.
(WebCore::Layout::Edges::height const): Deleted.
(WebCore::Layout::operator/): Deleted.
* Source/WebCore/layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::FloatAvoider):
(WebCore::Layout::FloatAvoider::setHorizontalPosition):
(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):
(WebCore::Layout::FloatAvoider::overflowsContainingBlock const):
* Source/WebCore/layout/floats/FloatAvoider.h:
(WebCore::Layout::FloatAvoider::marginBefore const):
(WebCore::Layout::FloatAvoider::marginAfter const):
(WebCore::Layout::FloatAvoider::marginStart const):
(WebCore::Layout::FloatAvoider::marginEnd const):
* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
* Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp:
(WebCore::Layout::FormattingGeometry::computedBorder const):
(WebCore::Layout::FormattingGeometry::computedPadding const):
* Source/WebCore/layout/formattingContexts/FormattingGeometry.h:
* Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeBorderAndPadding):
* Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::layout):
* Source/WebCore/layout/formattingContexts/flex/FlexRect.h:
(WebCore::Layout::FlexRect::marginTop const):
(WebCore::Layout::FlexRect::marginBottom const):
(WebCore::Layout::FlexRect::marginLeft const):
(WebCore::Layout::FlexRect::marginRight const):
(WebCore::Layout::FlexRect::setMarginTop):
(WebCore::Layout::FlexRect::setMarginBottom):
(WebCore::Layout::FlexRect::setMarginLeft):
(WebCore::Layout::FlexRect::setMarginRight):
(WebCore::Layout::FlexRect::FlexRect):
* Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace):
* Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.cpp:
(WebCore::Layout::TableFormattingGeometry::computedCellBorder const):
* Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.h:
* Source/WebCore/layout/formattingContexts/table/TableGrid.h:
(WebCore::Layout::TableGrid::setCollapsedBorder):
(WebCore::Layout::TableGrid::collapsedBorder const):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::Edges::width const):
(WebCore::Layout::BoxGeometry::Edges::height const):
(WebCore::Layout::toBoxGeometryEdges): Deleted.

Canonical link: https://commits.webkit.org/273076@main