[webkit-changes] [WebKit/WebKit] e1188e: [WGSL] shader, execution, expression, call, builtin, at...

Tadeu Zagallo noreply at github.com
Tue Jan 16 05:10:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1188ea0c298c77b48684d39dc94524f765b5520
      https://github.com/WebKit/WebKit/commit/e1188ea0c298c77b48684d39dc94524f765b5520
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTParameter.h
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WGSL] shader,execution,expression,call,builtin,atomics,atomicExchange:* is failing
https://bugs.webkit.org/show_bug.cgi?id=267550
rdar://121011079

Reviewed by Mike Wyrzykowski.

Threadgroup atomics need to be explicitly set to zero in the first invocation of
the threadgroup.

* Source/WebGPU/WGSL/AST/ASTParameter.h:
* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::visit):
(WGSL::EntryPointRewriter::appendBuiltins):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertMaterializations):
(WGSL::RewriteGlobalVariables::insertLocalDefinitions):
(WGSL::RewriteGlobalVariables::initializeAtomics):
(WGSL::RewriteGlobalVariables::insertWorkgroupBarrier):
(WGSL::RewriteGlobalVariables::findOrInsertLocalInvocationIndex):
(WGSL::RewriteGlobalVariables::atomicStoreInitialValue):

Canonical link: https://commits.webkit.org/273065@main




More information about the webkit-changes mailing list