[webkit-changes] [WebKit/WebKit] 9b890f: REGRESSION (Fullscreen API): cnn.com: Videos are z...

Antti Koivisto noreply at github.com
Tue Jan 16 03:48:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b890f5bbf67ee100a7e5962ee58168e82fa71d1
      https://github.com/WebKit/WebKit/commit/9b890f5bbf67ee100a7e5962ee58168e82fa71d1
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  REGRESSION (Fullscreen API): cnn.com: Videos are zoomed in when playing in full screen on iOS
https://bugs.webkit.org/show_bug.cgi?id=267543
rdar://119640248

Reviewed by Tim Nguyen.

The page uses bitmovin video player which correctly sets 'object-fit:contain' for the full screen
video element. However the page also has a style rule with equivalent specificity that sets 'object-fit:fill'.
The video player stylesheet is inserted dynamically and its position in the document varies, allowing
the 'fill' rule win under some circumstances.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsFullscreenObjectFitQuirk const):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):

Adjust the style 'object-fit:fill' -> 'object-fit:contain'

Canonical link: https://commits.webkit.org/273061@main




More information about the webkit-changes mailing list