[webkit-changes] [WebKit/WebKit] 3eabc1: RemoteImageBufferSet is leaked if the RemoteRender...

mattwoodrow noreply at github.com
Mon Jan 15 22:31:41 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3eabc15ebb801d9eb0ba7386f82a26ed9337b201
      https://github.com/WebKit/WebKit/commit/3eabc15ebb801d9eb0ba7386f82a26ed9337b201
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-01-15 (Mon, 15 Jan 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp

  Log Message:
  -----------
  RemoteImageBufferSet is leaked if the RemoteRenderingBackend is destroyed without removing them manually.
https://bugs.webkit.org/show_bug.cgi?id=267563
rdar://120057571>

Reviewed by Mike Wyrzykowski.

There's a reference cycle between m_remoteImageBufferSets on the
RemoteRenderingBackend, and m_backend on RemoteImageBufferSet.

Normally we remove them from the hash map manually, but if we shut
down the rendering backend entirely, any remaining sets (and the
rendering backend) are leaked.

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::workQueueUninitialize):

Canonical link: https://commits.webkit.org/273054@main




More information about the webkit-changes mailing list