[webkit-changes] [WebKit/WebKit] 04dd4e: Avoid traversing all custom properties in Styleabl...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04dd4ecfc6edde45a6517687ab7bf4ff9c66f36f
      https://github.com/WebKit/WebKit/commit/04dd4ecfc6edde45a6517687ab7bf4ff9c66f36f
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-01-15 (Mon, 15 Jan 2024)

  Changed paths:
    M Source/WebCore/css/CSSCustomPropertyValue.cpp
    M Source/WebCore/css/CSSCustomPropertyValue.h
    M Source/WebCore/rendering/style/StyleCustomPropertyData.cpp
    M Source/WebCore/rendering/style/StyleCustomPropertyData.h
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  Avoid traversing all custom properties in Styleable::updateCSSTransitions when not needed
https://bugs.webkit.org/show_bug.cgi?id=267536
rdar://121002539

Reviewed by Antoine Quint.

* Source/WebCore/css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::isAnimatable const):

Factor into a function.

* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/rendering/style/StyleCustomPropertyData.cpp:
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
(WebCore::StyleCustomPropertyData::set):

Check if the newly set property is animatable.

(WebCore::StyleCustomPropertyData::size const): Deleted.
* Source/WebCore/rendering/style/StyleCustomPropertyData.h:
(WebCore::StyleCustomPropertyData::size const):
(WebCore::StyleCustomPropertyData::mayHaveAnimatableProperties const):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::updateCSSTransitions const):

Bail out if before traversing if we already know the properties are not animatable.

Canonical link: https://commits.webkit.org/273045@main