[webkit-changes] [WebKit/WebKit] da94d3: [Win] Implement EventSenderProxy::mouseScrollByWit...

Fujii Hironori noreply at github.com
Sun Jan 14 22:46:08 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da94d34c7e762608e89adbf378476bb691481c7b
      https://github.com/WebKit/WebKit/commit/da94d34c7e762608e89adbf378476bb691481c7b
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-01-14 (Sun, 14 Jan 2024)

  Changed paths:
    M LayoutTests/platform/wincairo/TestExpectations
    M Source/WebCore/page/EventHandler.cpp
    M Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp

  Log Message:
  -----------
  [Win] Implement EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases
https://bugs.webkit.org/show_bug.cgi?id=267522

Reviewed by Ross Kirsling.

Some wheel event tests were failing becuase it was not implemented yet
for WebKitTestRunner of Windows port.

The arguments `phase` and `momentum` are used only if
ENABLE(KINETIC_SCROLLING) which is disabled for Windows port at the
moment. We can ignore them.

EventHandler::handleWheelEventInternal has to initiate a
WheelEventTestMonitorCompletionDeferrer to work WheelEventTestMonitor
correctly. Otherwise, `callback` of
WKBundlePageRegisterScrollOperationCompletionCallback never be called
back.

* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/page/EventHandler.cpp:
* Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp:

Canonical link: https://commits.webkit.org/273031@main




More information about the webkit-changes mailing list