[webkit-changes] [WebKit/WebKit] f4658f: [IFC][Geometry] Annotation BoxGeometry should be a...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4658f2ff4c126d1bf24a2c1fd76f7e639ed4860
      https://github.com/WebKit/WebKit/commit/f4658f2ff4c126d1bf24a2c1fd76f7e639ed4860
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-14 (Sun, 14 Jan 2024)

  Changed paths:
    M LayoutTests/platform/mac/fast/ruby/ruby-run-break-expected.txt
    M LayoutTests/platform/mac/fast/ruby/ruby-runs-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC][Geometry] Annotation BoxGeometry should be all logical
https://bugs.webkit.org/show_bug.cgi?id=267500

Reviewed by Antti Koivisto.

Last step of converting BoxGeometry coords to all logical.

While annotation box geometry is logical, the associated display box is (always) visual.
Also overlap checking (as part of the overhanging process) needs to happen in virtual coords.

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processRubyBase):
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::sizeAnnotationBox):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Canonical link: https://commits.webkit.org/273027@main