[webkit-changes] [WebKit/WebKit] f546b9: Wasm element segment vector items should allow mor...

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f546b9fda023108f0f5c5f85c737a8994da9930e
      https://github.com/WebKit/WebKit/commit/f546b9fda023108f0f5c5f85c737a8994da9930e
  Author: Asumu Takikawa <asumu at igalia.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M JSTests/wasm/extended-const-spec-tests/elem.wast.js
    M Source/JavaScriptCore/wasm/WasmInstance.cpp

  Log Message:
  -----------
  Wasm element segment vector items should allow more constant expressions
https://bugs.webkit.org/show_bug.cgi?id=260542

Reviewed by Justin Michaud.

This patch enables the test cases in the extended constant expression proposal
spec tests that were blocked by the item limitation.

It also fixes a bug uncovered by these tests, which is that the function table
initialization path for global/constant expression cases needs to be handled
explicitly.

The spec test tests the global.get case. The constant expression case is
difficult to test in practice, because currently you can only get a function
result from a constant expression via ref.null, ref.func, and global.get which
are all fast-path special cases and avoid the full constant expression parsing.

* JSTests/wasm/extended-const-spec-tests/elem.wast.js:
* Source/JavaScriptCore/wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::initElementSegment):

Canonical link: https://commits.webkit.org/273002@main