[webkit-changes] [WebKit/WebKit] 4ef616: AX: Refactor the TitleUIElement property using Lab...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ef6169e54ce65e7b1a213c7917a9ee69baf0e75
      https://github.com/WebKit/WebKit/commit/4ef6169e54ce65e7b1a213c7917a9ee69baf0e75
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M LayoutTests/accessibility/aria-hidden-negates-no-visibility-expected.txt
    M LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt
    M LayoutTests/accessibility/aria-labelledby-on-password-input.html
    M LayoutTests/accessibility/aria-labelledby-text-expected.txt
    M LayoutTests/accessibility/aria-labelledby-text.html
    M LayoutTests/accessibility/mac/aria-label-overrides-visible-text-expected.txt
    M LayoutTests/accessibility/mac/aria-label-overrides-visible-text.html
    M LayoutTests/accessibility/radio-button-title-label-expected.txt
    M LayoutTests/accessibility/radio-button-title-label.html
    R LayoutTests/accessibility/th-as-title-ui-expected.txt
    R LayoutTests/accessibility/th-as-title-ui.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt
    M LayoutTests/platform/mac/accessibility/aria-switch-text-expected.txt
    M LayoutTests/platform/mac/accessibility/w3c-svg-name-calculation-expected.txt
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityLabel.cpp
    M Source/WebCore/accessibility/AccessibilityLabel.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h
    M Source/WebCore/accessibility/AccessibilityTable.cpp
    M Source/WebCore/accessibility/AccessibilityTable.h
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Refactor the TitleUIElement property using LabeledBy and LabelFor relationships.
https://bugs.webkit.org/show_bug.cgi?id=262787
<rdar://problem/116581948>

Reviewed by Tyler Wilcock.

The TitleUIElement property was treated as being independent from the object's LabeledBy and LabelFor relationships. Conceptually, TitleUIElement and LabeledBy are the same concept, and indeed shared a lot of common code in the AccessibilityObject class hierarchy. This change unifies the implementation of TitleUIElement and the Label relationships in a coherent way.

With this change is no longer necessary to cache and update the TitleUIElement in the IsolatedObject as a separate property, but instead it is stored as a relationship. This change will also allow the addition of enhanced heuristics to determine label-object associations.

Some code and style cleanup is also part of the patch.

Canonical link: https://commits.webkit.org/273000@main