[webkit-changes] [WebKit/WebKit] 87194a: REGRESSION(272844 at main): [ wk2 ] imported/w3c/web-...

youennf noreply at github.com
Fri Jan 12 13:24:39 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87194aeb6d38425a3f7f3da731272c39008010dd
      https://github.com/WebKit/WebKit/commit/87194aeb6d38425a3f7f3da731272c39008010dd
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html
    M LayoutTests/platform/wk2/TestExpectations

  Log Message:
  -----------
  REGRESSION(272844 at main): [ wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html is consistently failing.
https://bugs.webkit.org/show_bug.cgi?id=267355
rdar://120798707

Reviewed by Eric Carlson.

The previous try to fix the flakiness was not taking into account the case of resize event firing to handle the transition from (0,0) to (160,160).
If it fires while onVideoChange is running, onVideoChange would spin as resizeEvent promise would not be recomputed and stay resolved.

We simply remove the resize event check and only rely on the setTimeout check which has the same frequency as the video frame emition by the canvas.

* LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html:
* LayoutTests/platform/wk2/TestExpectations:

Canonical link: https://commits.webkit.org/272990@main




More information about the webkit-changes mailing list