[webkit-changes] [WebKit/WebKit] e30eac: Store fewer raw pointers in HashMaps in worker code

Chris Dumez noreply at github.com
Fri Jan 12 08:55:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e30eaca9b4f63f5540473ecd965682d0f09be5ef
      https://github.com/WebKit/WebKit/commit/e30eaca9b4f63f5540473ecd965682d0f09be5ef
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M Source/WebCore/workers/Worker.cpp
    M Source/WebCore/workers/Worker.h
    M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
    M Source/WebCore/workers/service/ServiceWorkerContainer.h
    M Source/WebCore/workers/service/server/SWServer.cpp
    M Source/WebCore/workers/service/server/SWServer.h
    M Source/WebCore/workers/service/server/SWServerToContextConnection.h
    M Source/WebCore/workers/service/server/SWServerWorker.cpp
    M Source/WebCore/workers/service/server/SWServerWorker.h
    M Source/WebCore/workers/shared/SharedWorker.cpp
    M Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp
    M Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h

  Log Message:
  -----------
  Store fewer raw pointers in HashMaps in worker code
https://bugs.webkit.org/show_bug.cgi?id=267435

Reviewed by Ryosuke Niwa.

* Source/WebCore/workers/Worker.cpp:
(WebCore::WTF_REQUIRES_LOCK):
(WebCore::Worker::Worker):
(): Deleted.
* Source/WebCore/workers/Worker.h:
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
* Source/WebCore/workers/service/ServiceWorkerContainer.h:
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::addContextConnection):
(WebCore::SWServer::contextConnectionForRegistrableDomain):
(WebCore::SWServer::setInspectable):
* Source/WebCore/workers/service/server/SWServer.h:
(WebCore::SWServer::contextConnectionForRegistrableDomain): Deleted.
* Source/WebCore/workers/service/server/SWServerToContextConnection.h:
(WebCore::SWServerToContextConnection::identifier const): Deleted.
(WebCore::SWServerToContextConnection::shouldTerminateWhenPossible const): Deleted.
(WebCore::SWServerToContextConnection::registrableDomain const): Deleted.
(WebCore::SWServerToContextConnection::serviceWorkerPageIdentifier const): Deleted.
* Source/WebCore/workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::allWorkers):
(WebCore::m_lastNavigationWasAppInitiated):
(): Deleted.
* Source/WebCore/workers/service/server/SWServerWorker.h:
* Source/WebCore/workers/shared/SharedWorker.cpp:
(WebCore::allSharedWorkers):
(): Deleted.
* Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:
(WebCore::allSharedWorkerThreadProxies):
(WebCore::SharedWorkerThreadProxy::SharedWorkerThreadProxy):
(WebCore::SharedWorkerThreadProxy::networkStateChanged):
(): Deleted.
* Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:

Canonical link: https://commits.webkit.org/272976@main




More information about the webkit-changes mailing list