[webkit-changes] [WebKit/WebKit] 274953: [GStreamer][WebRTC] Missing support for parameter-...

Philippe Normand noreply at github.com
Fri Jan 12 04:50:28 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 274953f826fda3160e7f955ed548b0da35f6f71d
      https://github.com/WebKit/WebKit/commit/274953f826fda3160e7f955ed548b0da35f6f71d
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-01-12 (Fri, 12 Jan 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-parameterless.https-expected.txt
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] Missing support for parameter-less setLocalDescription()
https://bugs.webkit.org/show_bug.cgi?id=265860

Reviewed by Xabier Rodriguez-Calvar.

Minimal support for parameter-less setLocalDescription() calls, by creating the offer or answer
ourselves. Ideally this should be done by webrtcbin, but until then, we workaround the issue.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-parameterless.https-expected.txt: Added.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::fetchDescription):
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::setDescription):
(WebCore::GStreamerMediaEndpoint::configureAndLinkSource):
(WebCore::GStreamerMediaEndpoint::requestPad):
(WebCore::GStreamerMediaEndpoint::initiate):
(WebCore::GStreamerMediaEndpoint::onIceGatheringChange):
(WebCore::GStreamerMediaEndpoint::onIceCandidate):

Canonical link: https://commits.webkit.org/272968@main




More information about the webkit-changes mailing list